Skip to content

fix(native-chat): recover steward active-cascade resume_failed and bound thinking-only error loops - #9170

Merged
loopx-agent merged 1 commit into
mainfrom
codex/steward-active-cascade-recovery-20261121
Nov 21, 2026
Merged

loopx-agent merged 1 commit into
mainfrom
codex/steward-active-cascade-recovery-20261121

Conversation

@loopx-agent

Copy link
Copy Markdown
Collaborator

Goal And Delivered Outcome

  • Outcome basis / optional anchor: Bug fix & resilience improvement on Antigravity Steward pre-dispatch resume_failed recovery and stream-interruption timeout handling (personal-native-bots-20261004).
  • Goal/source and gap:
    1. When an Antigravity Steward turn collected manager.context before native dispatch and hit resume_failed with "The original Antigravity conversation is still active. Stop it in Antigravity before retrying.", planRuntimePreparationRecovery in conversation_binding.ts rejected recovery because it only matched "The previous Agent conversation could not be restored." and required started_at === null && first_event_at === null && events.length === 2, while _preparation_scope_available in external_conversations.py only checked Language Server reachability without verifying GetCascadeTrajectory.status == "CASCADE_RUN_STATUS_IDLE".
    2. discover_antigravity_language_server in antigravity_adapter.py checked only ANTIGRAVITY_LS_URL alongside ANTIGRAVITY_CSRF_TOKEN and returned None when hosts provided ANTIGRAVITY_LS_ADDRESS instead.
    3. In AntigravityAdapter._run_turn, repeated CORTEX_STEP_TYPE_ERROR_MESSAGE -> thinking-only CORTEX_STEP_TYPE_PLANNER_RESPONSE retry cycles with no visible response text or tool calls repeatedly reset last_progress_at, preventing ANTIGRAVITY_IDLE_TIMEOUT_SEC from cancelling a wedged cascade.
  • Observable before -> after:
    • Before: Pre-dispatch Steward resume_failed ("The original Antigravity conversation is still active...") after manager.context could never auto-recover; _preparation_scope_available did not gate on CASCADE_RUN_STATUS_IDLE; ANTIGRAVITY_LS_ADDRESS + ANTIGRAVITY_CSRF_TOKEN env configuration returned None; thinking-only retry loops after non-cleared errors never hit the idle timeout.
    • After: planRuntimePreparationRecovery admits strictly verified Antigravity Steward manager.context pre-dispatch resume_failed turns (upstream_turn_id === null, delta_count === 0, response === null), _preparation_scope_available defers retry while the cascade is running and admits recovery once CASCADE_RUN_STATUS_IDLE, discover_antigravity_language_server resolves ANTIGRAVITY_LS_ADDRESS + ANTIGRAVITY_CSRF_TOKEN, and _run_turn ignores non-progressing thinking-only retry steps after non-cleared errors so idle timeout cancels the wedged cascade cleanly.
  • Verification run locally:
    • node --experimental-strip-types --test tests/control_plane_ts/conversation_binding.test.ts (70 passed, 0 failed)
    • uv run --extra test python -m pytest tests/test_chat_runtime_preparation_recovery.py tests/test_antigravity_steward_adapter.py tests/test_antigravity_host_runtime.py tests/test_audit_cli_and_runtime_fixes.py -q (216 passed)
    • uv run --extra test ruff check ... (All checks passed!)
    • uv run --extra test loopx canary premerge --from-git-diff --git-diff-base origin/main --tier quick (ok: true, failures: 0)

Author Declaration

  • Written by: model_agent (Gemini family, Google)

…und thinking-only error loops

Signed-off-by: LoopX Agent <[email protected]>

@loopx-agent loopx-agent left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval conclusion (author-owned PR; GitHub blocks formal self-approval)

Reviewer: model_agent (declared_model=Gemini, declared_provider=Google, declaration_source=self_reported)
Target exact head: 9170@fe10fa4cc10a0b3447aab9b75313618f310fa6a0

动机

  • Affected caller or operator: LoopX personal-steward and local Antigravity Language Server callers.
  • Before/after scenario: Before: restarting the chat service during an Antigravity turn left the upstream cascade retrying thinking-only error loops while the next Steward turn failed pre-dispatch after manager.context and could never auto-recover. After: post-error thinking-only loops time out and cancel, _preparation_scope_available waits until CASCADE_RUN_STATUS_IDLE, and planRuntimePreparationRecovery admits exactly verified Steward manager.context pre-dispatch resume_failed turns.
  • Observable outcome: 70/70 TS conversation_binding tests pass, 216 Python tests pass including live Steward active-cascade recovery and thinking-only error-loop timeout tests, ruff and quick canary premerge pass with 0 failures.
  • Non-goals: Does not alter Codex routing recovery or post-dispatch result review contracts.

实际运行中一旦宿主重启中断了 Antigravity 原生对话,原有级联会持续陷入纯思考重试死循环并拒绝后续排队的 Steward 消息;若不修复预派发恢复条件与级联空闲门禁,用户消息将永久卡在失败态而无法自动续接。

改动思路

本 PR 在既有状态机边界内做最小可逆修复:Minimal reversible fix directly in the three owning modules (TS recovery policy, Python preparation availability readback, and Antigravity adapter progress/discovery).。边界约束:Limited strictly to Antigravity Steward pre-dispatch active-cascade resume_failed recovery, LS env address fallback, and non-progressing post-error thinking-only retry timeout; Codex recovery and post-dispatch flows remain untouched.。

具体包含三条协同机制:第一,在 TypeScript 控制面允许经过严格前置事件校验(包含 manager.context 与 turn.failed 且 upstream_turn_id === null、delta_count === 0、response === null、execution_dispatch == null)的 Antigravity Steward resume_failed(The original Antigravity conversation is still active...)进入有界准备恢复;第二,在 Python 准备可用性检查中读取 GetCascadeTrajectory,仅当状态为 CASCADE_RUN_STATUS_IDLE 时开放接续;第三,在 Antigravity 适配层补全 ANTIGRAVITY_LS_ADDRESS 发现并在 _run_turn 中忽略非 CLEARED 错误后的纯思考无进展重试步,确保死循环能触发 idle 超时取消。

具体改动

  1. loopx/control_plane/collaboration/conversation_binding.ts(planRuntimePreparationRecovery,第 1649 行):扩展 expectedErrors 仅在 current.agent_id === "antigravity" 时接受 "The original Antigravity conversation is still active. Stop it in Antigravity before retrying.";同时放行带有完整 manager.context 前置事件链、未派发且无正文增量的 Steward 预派发失败记录,并通过反向单测验证任意 upstream_turn_id、execution_dispatch 或缺失 manager.context 的请求继续被拒绝。
  2. loopx/capabilities/native_chat/external_conversations.py(_preparation_scope_available,第 732 行):当会话使用 antigravity 且存在 upstream_thread_id 时,读取 GetCascadeTrajectory,在运行中时返回 False 延后重入(不消耗重试预算),仅在 CASCADE_RUN_STATUS_IDLE 时返回 True。
  3. loopx/capabilities/native_chat/antigravity_adapter.py(discover_antigravity_language_server 与 _run_turn):在未设置 ANTIGRAVITY_LS_URL 但提供 ANTIGRAVITY_CSRF_TOKEN 时兼容回退 ANTIGRAVITY_LS_ADDRESS 并校验回环地址;在 _run_turn 进度计算中排除首个非 CLEARED 错误之后既无响应文本也无 toolCalls 的纯 thinking 重试步,防止空转无限重置空闲计时器。
  4. 测试覆盖:tests/control_plane_ts/conversation_binding.test.ts 新增 Steward 预派发恢复与负向边界用例(70/70 通过);tests/test_chat_runtime_preparation_recovery.py 新增运行中延迟恢复至空闲后完成交付的端到端测试;tests/test_antigravity_steward_adapter.py 新增环境变量发现与错误纯思考循环超时取消测试(216 passed)。

对主干的风险

对主干的影响高度受控且局限于 Antigravity Steward 路径:对于正常执行的会话以及 Codex 会话,控制面判定与适配层进度刷新逻辑完全保持不变。唯一边界条件是当 Antigravity 在一次非 CLEARED 错误之后连续处于纯思考而超过 600 秒未产生任何可见输出或工具调用时,适配层会按 idle 超时主动中断并调用 CancelCascadeInvocation,这是期望的兜底保护而非回归。若未来需要调整错误识别策略,只需回退或调整三处局部守卫,不涉及任何持久化 Schema 迁移或配置变更。

我的整体评价

该改动精准定位并闭合了 Antigravity 管家在服务重启后的两个连锁缺陷(死循环无法超时与预派发无法自愈),控制面与适配层职责清晰,正反测试与本地预合并门禁(TS 单测 70/70、Python 单测 216 passed、ruff check、canary premerge quick failures: 0)全部通过。架构边界评估:Limited strictly to Antigravity Steward pre-dispatch active-cascade resume_failed recovery, LS env address fallback, and non-progressing post-error thinking-only retry timeout; Codex recovery and post-dispatch flows remain untouched. 原因:Minimal reversible fix directly in the three owning modules (TS recovery policy, Python preparation availability readback, and Antigravity adapter progress/discovery).。视觉评审结论:No rendered frontend or UI component modified; backend control-plane and Python native chat adapter only. 未验证范围:none。

English Verdict: APPROVE

@loopx-agent
loopx-agent merged commit d083494 into main Nov 21, 2026
12 of 15 checks passed
@loopx-agent
loopx-agent deleted the codex/steward-active-cascade-recovery-20261121 branch November 21, 2026 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant